From 9ed2186f668c76aeb472de170d62b499d85a1915 Mon Sep 17 00:00:00 2001 From: Marc Deslauriers Date: Tue, 15 Jul 2025 13:34:08 -0400 Subject: [PATCH] udiskslinuxmanager: Add lower bounds check to fd_index Make sure fd_index isn't negative as this can lead to an OOB read resulting in a crash, or to exposing internal file descriptors. Reported by Michael Imfeld (born0monday). (cherry picked from commit 280b127124332c6436bc8273ef677f218b435593) --- src/udiskslinuxmanager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/udiskslinuxmanager.c b/src/udiskslinuxmanager.c index 491edb92b..317d7ce6a 100644 --- a/src/udiskslinuxmanager.c +++ b/src/udiskslinuxmanager.c @@ -381,7 +381,7 @@ handle_loop_setup (UDisksManager *object, goto out; fd_num = g_variant_get_handle (fd_index); - if (fd_list == NULL || fd_num >= g_unix_fd_list_get_length (fd_list)) + if (fd_list == NULL || fd_num < 0 || fd_num >= g_unix_fd_list_get_length (fd_list)) { g_dbus_method_invocation_return_error (invocation, UDISKS_ERROR,